[vlc-devel] [PATCH] opengl: fix return value on error

Romain Vimont rom1v at videolabs.io
Mon Dec 2 16:22:44 CET 2019


opengl_fragment_shader_init_impl() returns a fragment shader object (a
GLuint), not a VLC status code.
---
 modules/video_output/opengl/fragment_shaders.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/video_output/opengl/fragment_shaders.c b/modules/video_output/opengl/fragment_shaders.c
index 9294ab6283..9694b52d63 100644
--- a/modules/video_output/opengl/fragment_shaders.c
+++ b/modules/video_output/opengl/fragment_shaders.c
@@ -507,7 +507,7 @@ opengl_fragment_shader_init_impl(opengl_tex_converter_t *tc, GLenum tex_target,
 
     const vlc_chroma_description_t *desc = vlc_fourcc_GetChromaDescription(chroma);
     if (desc == NULL)
-        return VLC_EGENERIC;
+        return 0;
 
     if (chroma == VLC_CODEC_XYZ12)
         return xyz12_shader_init(tc);
-- 
2.24.0



More information about the vlc-devel mailing list