[vlc-devel] [PATCH 1/3] libvlc: improve libvlc_video_set_key_input prototype

[Alexandre Janniaux]

Hi,

I agree that the default to off/false for both values will be
better, but what is the point of renaming? Changing the
default value won't change the behaviour of the function and
changing the function name won't change anything for
applications which never call this function.

Or you're talking about renaming the `unsigned on` into
`unsigned off` and changing the behaviour of the function, in
which case I don't see the point.

If this is the first case, changing the default value is
independant of changing the parameter from unsigned to bool.

Regards,
--
Alexandre Janniaux

On Tue, Dec 03, 2019 at 12:21:14PM +0200, Rémi Denis-Courmont wrote:
> Because almost every app dev wants the opposite than default, and stumble upon this problem.
>
> Le 3 décembre 2019 10:42:46 GMT+02:00, Alexandre Janniaux <ajanni at videolabs.io> a écrit :
> >Hi,
> >
> >On Mon, Dec 02, 2019 at 07:41:34PM +0200, Rémi Denis-Courmont wrote:
> >> Le maanantaina 2. joulukuuta 2019, 16.28.51 EET Alexandre Janniaux a
> >écrit :
> >> > Use booleans instead of unsigned when taking a boolean value.
> >>
> >> IMO we should also switch the default values to off and preferably
> >rename the
> >> functions so that there's a blatant breakage to be fixed in using
> >code.
> >
> >Care to explain why?
> >
> >
> >Regards,
> >--
> >Alexandre Janniaux
> >Videolabs
> >_______________________________________________
> >vlc-devel mailing list
> >To unsubscribe or modify your subscription options:
> >https://mailman.videolan.org/listinfo/vlc-devel
>
> --
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.

> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel