[vlc-devel] [PATCH 1/2] qt: mlnetworkdevicemodel: fix warnings

Alexandre Janniaux ajanni at videolabs.io
Tue Dec 3 16:55:41 CET 2019


Hi,

Ping :)

Regards,
--
Alexandre Janniaux
Videolabs

On Sun, Nov 17, 2019 at 07:16:34PM +0100, Alexandre Janniaux wrote:
> ---
>  .../gui/qt/components/mediacenter/mlnetworkdevicemodel.cpp  | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/modules/gui/qt/components/mediacenter/mlnetworkdevicemodel.cpp b/modules/gui/qt/components/mediacenter/mlnetworkdevicemodel.cpp
> index 8979a19836..316dcd6f1f 100644
> --- a/modules/gui/qt/components/mediacenter/mlnetworkdevicemodel.cpp
> +++ b/modules/gui/qt/components/mediacenter/mlnetworkdevicemodel.cpp
> @@ -116,7 +116,7 @@ bool MLNetworkDeviceModel::addToPlaylist(int index)
>  {
>      if (!(m_ctx && m_sdSource != CAT_MYCOMPUTER))
>          return false;
> -    if (index < 0 || index >= m_items.size() )
> +    if (index < 0 || (size_t)index >= m_items.size() )
>          return false;
>      auto item =  m_items[index];
>      vlc::playlist::Media media{ item.inputItem.get() };
> @@ -141,7 +141,7 @@ bool MLNetworkDeviceModel::addAndPlay(int index)
>  {
>      if (!(m_ctx && m_sdSource != CAT_MYCOMPUTER))
>          return false;
> -    if (index < 0 || index >= m_items.size() )
> +    if (index < 0 || (size_t)index >= m_items.size() )
>          return false;
>      auto item =  m_items[index];
>      vlc::playlist::Media media{ item.inputItem.get() };
> @@ -211,7 +211,7 @@ void MLNetworkDeviceModel::onItemCleared( MediaSourcePtr mediaSource, input_item
>      refreshDeviceList( std::move( mediaSource), node->pp_children, node->i_children, true );
>  }
>
> -void MLNetworkDeviceModel::onItemAdded( MediaSourcePtr mediaSource, input_item_node_t* parent,
> +void MLNetworkDeviceModel::onItemAdded( MediaSourcePtr mediaSource, input_item_node_t*,
>                                    input_item_node_t *const children[],
>                                    size_t count )
>  {
> --
> 2.24.0
>


More information about the vlc-devel mailing list