[vlc-devel] [PATCH] contrib: lame: disable asserts

Alexandre Janniaux ajanni at videolabs.io
Mon Dec 9 17:29:14 CET 2019


LGTM, meson people also seem to expose NDEBUG by the way.

Just nit on the (excellent) commit message.

On Mon, Dec 09, 2019 at 05:02:19PM +0100, Thomas Guillem wrote:
> As the lame INSTALL says:
> "For production use, be sure to compile a "Release" target, with the "maximum
> speed" compile option, and #define NDEBUG."
> It will fix an assert on psymodel.c:576 that could happen when feeding data
> after a flush. There is no possible memory corruption but maybe a read of
> invalid data that could trigger an audio glitch. Due to the rarity of this bug
> (happening only via chromecast, with some input files and with a lot of seek
> requests), I think that such fix is enough.
> PS: the contrib WITH_OPTIMIZATION option should be split into OPTIMS and DEBUG.

This PS should probably be moved to a trac ticket instead of
being in this commit.

Alexandre Janniaux

More information about the vlc-devel mailing list