[vlc-devel] [PATCH] http: link vlccore through LDFLAGS

[Steve Lhomme]

On 2019-12-11 14:07, Rémi Denis-Courmont wrote:
> Strictly speaking, it's a bug in the plugin targets, not in the HTTP lib...

What bug ? The fact the http module is always linked whenever the core 
is relinked ?

> Le 11 décembre 2019 13:42:59 GMT+02:00, Steve Lhomme <robux4 at ycbcr.xyz> 
> a écrit :
> 
>     Like every other module.
> 
>     So it doesn't link everytime something is commited on git.
>     ------------------------------------------------------------------------
>       modules/access/http/Makefile.am | 4 ++--
>       1 file changed, 2 insertions(+), 2 deletions(-)
> 
>     diff --git a/modules/access/http/Makefile.am b/modules/access/http/Makefile.am
>     index 8054457b6c0..85571b741f1 100644
>     --- a/modules/access/http/Makefile.am
>     +++ b/modules/access/http/Makefile.am
>     @@ -16,10 +16,10 @@ libvlc_http_la_SOURCES = \
>       	access/http/chunked.c access/http/tunnel.c access/http/conn.h \
>       	access/http/connmgr.c access/http/connmgr.h
>       libvlc_http_la_CPPFLAGS = -Dneedsomethinghere
>     -libvlc_http_la_LIBADD = $(LTLIBVLCCORE) ../compat/libcompat.la $(SOCKET_LIBS)
>     +libvlc_http_la_LIBADD = $(SOCKET_LIBS)
>       #libvlc_http_la_LDFLAGS = -no-undefined -export-symbols-regex ^vlc_http_
>       #pkglib_LTLIBRARIES += libvlc_http.la
>     -libvlc_http_la_LDFLAGS = -static
>     +libvlc_http_la_LDFLAGS = $(top_builddir)/compat/libcompat.la $(LTLIBVLCCORE) -static
>       noinst_LTLIBRARIES += libvlc_http.la
>       
>       hpack_test_SOURCES = access/http/hpack.c access/http/hpack.h
> 
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser 
> ma brièveté.
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>