[vlc-devel] [PATCH 1/2] avformat: mux: handle subtitle metadata

[Alexandre Janniaux]

Hi,

On Wed, Dec 11, 2019 at 04:30:24PM +0100, Francois Cartegnie wrote:
> Le 11/12/2019 à 16:23, Alexandre Janniaux a écrit :
> >
> > +    case SPU_ES:
> > +        codecpar->codec_type = AVMEDIA_TYPE_SUBTITLE;
> > +        av_dict_set( &stream->metadata, "title", fmt->psz_description, 0 );
> > +        av_dict_set( &stream->metadata, "language", fmt->psz_language, 0 );
> > +        break;
> > +
>
> * language is unlikely to match the expected format.

What do you mean? We don't seem to change the psz_language
value when parsing it. Is the parsing incorrect too or should
it need codec-specific transformation in the core when
parsing before?

I'm far from being knowledgeable when it comes to subtitles
so don't hesitate to be really meticulous on this. :)

> * better not create empty value for keys

Indeed, good catch thank you.

Regards,
--
Alexandre Janniaux
Videolabs