[vlc-devel] [PATCH 1/3] contrib: avoid clang warning about invalid compiler arguments

Steve Lhomme robux4 at ycbcr.xyz
Tue Dec 17 15:29:35 CET 2019


On 2019-12-17 15:20, Alexandre Janniaux wrote:
> Hi,
> 
> This should probably be checked against Apple builds too.

If I push it somewhere on Gitlab can it be checked against all targets ?

> Regards,
> --
> Alexandre Janniaux
> Videolabs
> 
> On Tue, Dec 17, 2019 at 03:09:27PM +0100, Steve Lhomme wrote:
>> They may be targeted at gcc and don't know about clang.
>> ---
>>   contrib/src/main.mak | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/contrib/src/main.mak b/contrib/src/main.mak
>> index 7d701626ba4..4425ab3f1d7 100644
>> --- a/contrib/src/main.mak
>> +++ b/contrib/src/main.mak
>> @@ -183,6 +183,7 @@ endif
>>
>>   ifneq ($(findstring clang, $(shell $(CC) --version 2>/dev/null)),)
>>   HAVE_CLANG := 1
>> +EXTRA_CFLAGS += -Werror=invalid-command-line-argument
>>   endif
>>
>>   cppcheck = $(shell $(CC) $(CFLAGS) -E -dM - < /dev/null | grep -E $(1))
>> --
>> 2.17.1
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> 


More information about the vlc-devel mailing list