[vlc-devel] [PATCH 2/3] configure: add -Werror=incompatible-pointer-types option to the compiler

Alexandre Janniaux ajanni at videolabs.io
Wed Dec 18 10:30:45 CET 2019


On Wed, Dec 18, 2019 at 10:16:24AM +0100, Steve Lhomme wrote:
> On 2019-12-18 10:03, RĂ©mi Denis-Courmont wrote:
> > That's exactly what's wrong. They're warnings and they should stay that way.
> I disagree.
> > You're welcome to attend to them.
> I can't compile on macOS, iOS or Android. Should I check the full logs of
> each MR I'm doing on Gitlab to see if somewhere there's a change I did that
> is doing something bad ? Will you ?

We should probably have assertions to check that the
public interface is correct anyway, but it raises the
question about how to run these tests on iOS indeed.

Maybe we can discuss on how to improve the robustness of
submission here instead of transforming warnings into errors.

For instance, buildbots are sometimes able to tell how many
new warnings have been added with a MR before mergin it, it
would help highlight these issues and prevent adding more
warnings unwillingly.

Alexandre Janniaux

More information about the vlc-devel mailing list