[vlc-devel] [PATCH 2/3] configure: add -Werror=incompatible-pointer-types option to the compiler

[Steve Lhomme]

On 2019-12-18 10:51, Steve Lhomme wrote:
> On 2019-12-18 10:30, Alexandre Janniaux wrote:
>> Hi,
>>
>> On Wed, Dec 18, 2019 at 10:16:24AM +0100, Steve Lhomme wrote:
>>> On 2019-12-18 10:03, Rémi Denis-Courmont wrote:
>>>> That's exactly what's wrong. They're warnings and they should stay 
>>>> that way.
>>>
>>> I disagree.
>>>
>>>> You're welcome to attend to them.
>>>
>>> I can't compile on macOS, iOS or Android. Should I check the full 
>>> logs of
>>> each MR I'm doing on Gitlab to see if somewhere there's a change I 
>>> did that
>>> is doing something bad ? Will you ?
>>
>> We should probably have assertions to check that the
>> public interface is correct anyway, but it raises the
>> question about how to run these tests on iOS indeed.
>>
>> Maybe we can discuss on how to improve the robustness of
>> submission here instead of transforming warnings into errors.
> 
> Yes, because pushing patches that breaks other systems than the one you 
> test with should not be allowed. And so we need to find ways to ensure 
> it doesn't happen when switching to Gitlab.

Also it's particularly sensible for the hardware decoding API, since it 
can hardly be tested by the CI bot.

>> For instance, buildbots are sometimes able to tell how many
>> new warnings have been added with a MR before mergin it, it
>> would help highlight these issues and prevent adding more
>> warnings unwillingly.
>>
>> Regards,
>> -- 
>> Alexandre Janniaux
>> Videolabs
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel