[vlc-devel] [PATCH] Widen STRNCATF temporary buffer

Marc Gonzalez marc.w.gonzalez at free.fr
Thu Dec 19 11:53:25 CET 2019


From: Marc Gonzalez <marc.w.gonzalez at free.fr>
Date: Thu, 19 Dec 2019 11:36:26 +0100

The temporary buffer used in STRNCATF is too small for a few callers,
which could lead to truncated output in some situations.

Signed-off-by: Marc Gonzalez <marc.w.gonzalez at free.fr>
---
 src/third_party/libdisasm/x86_format.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/third_party/libdisasm/x86_format.c b/src/third_party/libdisasm/x86_format.c
index 0ec960dc..8e83247e 100644
--- a/src/third_party/libdisasm/x86_format.c
+++ b/src/third_party/libdisasm/x86_format.c
@@ -29,7 +29,7 @@
 } while( 0 )
 
 #define STRNCATF( buf, fmt, data, len ) do {        \
-        char _tmp[MAX_OP_STRING];                   \
+        char _tmp[64];                              \
                                                     \
         snprintf( _tmp, sizeof _tmp, fmt, data );   \
         STRNCAT( buf, _tmp, len );                  \
-- 
2.17.1


More information about the vlc-devel mailing list