[vlc-devel] [PATCH] hotkeys: get the boss-key to work reliably

[vikalp bhandari]

Hi

Boss key is unreliable for fullscreen on ubuntu. If pressed during
fullscreen, the player leaves the full screen and pauses the playback. But
the screen does not gets minimised to tray.

I think this is due to some issue with Qt. So I want to switch off the full
screen first, and then call the Qt functions.

Since there is a togggle fullscreen hotkey which toggles the fullscreen
without using Qt, I used the same code.

Please comment how should I improve this.

On Tue, 5 Feb 2019, 13:12 Steve Lhomme, <robux4 at ycbcr.xyz> wrote:

> Hi,
>
> This is not how key mapping should work. Looking at the code the Qt and
> OS X interfaces both handle the boss key event. If you want to handle
> the fullscreen it should be done there. But looking at the code using
> the boss key twice gets back to the previous state. That's not what your
> code does.
>
> Also what is currently unreliable ?
>
> On 04/02/2019 20:08, Vikalp Bhandari 97vikalp at gmail.com wrote:
> > turn off fullscreen before triggering callback
> > ---
> >   modules/control/hotkeys.c | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/modules/control/hotkeys.c b/modules/control/hotkeys.c
> > index 6c60deaf09..533ff7df5a 100644
> > --- a/modules/control/hotkeys.c
> > +++ b/modules/control/hotkeys.c
> > @@ -401,6 +401,9 @@ static int PutAction( intf_thread_t *p_intf,
> input_thread_t *p_input,
> >               var_TriggerCallback( p_playlist, "intf-toggle-fscontrol" );
> >               break;
> >           case ACTIONID_INTF_BOSS:
> > +            if( p_vout )
> > +                var_SetBool( p_vout, "fullscreen", false );
> > +            var_SetBool( p_playlist, "fullscreen", false );
> >               var_TriggerCallback( p_playlist, "intf-boss" );
> >               break;
> >           case ACTIONID_INTF_POPUP_MENU:
> > --
> > 2.17.1
> >
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190205/39365e67/attachment.html>