[vlc-devel] [PATCH 2/4] viewpoint: add euler to 4x4 matrix conversion

Alexandre Janniaux ajanni at videolabs.io
Thu Feb 7 13:15:26 CET 2019

On 2019-02-07 12:59, RĂ©mi Denis-Courmont wrote:
> Are you sure that you should do intermediate computations in double
> precision? That does not seem useful here.

Hi, Thank you for your comment.

Yes, it's not really useful as there is no drift to take account here, 
but it's
not harmful too and I found it more readable than doing:

+    vp.yaw *= (float) M_PI; vp.pitch *= (float) M_PI; vp.roll *= 
(float) M_PI;

Would you still prefer the single precision one?

More information about the vlc-devel mailing list