[vlc-devel] [PATCH] configure: enable debug by default

[Steve Lhomme]

On 07/02/2019 13:26, Hugo Beauzée-Luyssen wrote:
> On Thu, Feb 7, 2019, at 1:23 PM, Thomas Guillem wrote:
>> It seems that lot of developers forget to enable this option. This option
>> enables assert and other debug codes (like the very useful thread/mutex debug
>> code) that should be mandatory when you dev on VLC.
>>
>> This is quite a big change: all VLC maintainers should now add
>> "--disable-debug" when they release a stable version of VLC.
>> ---
>>   configure.ac | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 9453dd852b..4f4b6b395a 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -979,9 +979,9 @@ dnl
>>   dnl  Debugging mode
>>   dnl
>>   AC_ARG_ENABLE([debug],
>> -  AS_HELP_STRING([--enable-debug],
>> -    [build with run-time assertions (default disabled)]),,
>> -  [enable_debug="no"])
>> +  AS_HELP_STRING([--disable-debug],
>> +    [build with run-time assertions (default enabled)]),,
>> +  [enable_debug="yes"])
>>   AH_TEMPLATE(NDEBUG,
>>               [Define to 1 if debug code should NOT be compiled])
>>   AS_IF([test "${enable_debug}" != "no"], [
> I like the idea, but this implies we go through all our build scripts (for instance, the win32 one uses --enable-debug) and adjust accordingly.
> Regardless of the patch being applied or not, we might want to explicitly tweak those scripts to explicitly provide --enable/--disable-debug.

That seems a more sensible approach so that a developer cannot forget 
it. And maintainers will also have to adjust their script.