[vlc-devel] [PATCH] codec: vpx: Detect libvpx 1.8.0 and, if detected, use fewer frame formats in the chroma_table

Steve Lhomme robux4 at ycbcr.xyz
Tue Feb 12 08:46:14 CET 2019


On 12/02/2019 08:38, Steve Lhomme wrote:
> Hi,
>
> Currently the contribs have 1.7.0. Does that mean the newer libvpx 
> supports less chroma formats ?

Yes
https://github.com/webmproject/libvpx/commit/c9a459216dc3d33db60147d14caad58c586f354b#diff-d733633e015464f768ebe1cbf0a2433b

The ABI version change is in the same commit, so it doesn't even depend 
on a release of libvpx.

Patch merged in 4.0 and will be backported to 3.0.

Thanks !

>
> On 11/02/2019 16:07, Danny Milosavljevic wrote:
>>
>> vlc-3.0.6-fix-libvlx-1.8.0-bindings.patch
>>
>> --- vlc-3.0.6/modules/codec/vpx.c.orig    2019-02-11 
>> 14:58:17.425370043 +0100
>> +++ vlc-3.0.6/modules/codec/vpx.c    2019-02-11 14:58:18.733372899 +0100
>> @@ -116,6 +116,7 @@
>>       { VLC_CODEC_I440, VPX_IMG_FMT_I440, 8, 0 },
>>         { VLC_CODEC_YV12, VPX_IMG_FMT_YV12, 8, 0 },
>> +#if VPX_IMAGE_ABI_VERSION < 5
>>       { VLC_CODEC_YUVA, VPX_IMG_FMT_444A, 8, 0 },
>>       { VLC_CODEC_YUYV, VPX_IMG_FMT_YUY2, 8, 0 },
>>       { VLC_CODEC_UYVY, VPX_IMG_FMT_UYVY, 8, 0 },
>> @@ -128,7 +129,7 @@
>>         { VLC_CODEC_ARGB, VPX_IMG_FMT_ARGB, 8, 0 },
>>       { VLC_CODEC_BGRA, VPX_IMG_FMT_ARGB_LE, 8, 0 },
>> -
>> +#endif
>>       { VLC_CODEC_GBR_PLANAR, VPX_IMG_FMT_I444, 8, 1 },
>>       { VLC_CODEC_GBR_PLANAR_10L, VPX_IMG_FMT_I44416, 10, 1 },
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel



More information about the vlc-devel mailing list