[vlc-devel] [vlc-commits] macosx: implement seeking and playback position display within the main window

Felix Paul Kühne fkuehne at videolan.org
Tue Feb 12 10:40:23 CET 2019

Hi David,

> On 11. Feb 2019, at 19:08, David Fuhrmann <david.fuhrmann at gmail.com> wrote:
> This looks problematic for me:
> vlc_player_GetCurrentMedia does not seem to increase any refcount of the input_item_t instance, so this getter seems to return an instance which is not safe to use afterwards. Also, the (objc) getter directly locks and then again unlocks the player, which is always a pattern being likely wrong.   
> Do I assume right if we would use the input_item_t within the lock it would be ok, but not outside anymore?

Very well spotted. You’ll see a commit shortly addressing the issue by implementing correct refcounting for the item.

Thanks for your review!

Best regards,


More information about the vlc-devel mailing list