[vlc-devel] [vlc-commits] configure: also set PKG_CONFIG_LIBDIR for the contribs

[Steve Lhomme]

On 14/02/2019 15:39, Hugo Beauzée-Luyssen wrote:
> On Thu, Feb 14, 2019, at 3:25 PM, Jean-Baptiste Kempf wrote:
>> I don't think this is a correct fix, tbh.
>>
>> On Thu, 14 Feb 2019, at 08:03, Steve Lhomme wrote:
>>> vlc | branch: master | Steve Lhomme <robux4 at ycbcr.xyz> | Wed Feb 13
>>> 15:39:09 2019 +0100| [fbb7265fa138aa4012d570eca9119ab35a3e579b] |
>>> committer: Steve Lhomme
>>>
>>> configure: also set PKG_CONFIG_LIBDIR for the contribs
>>>
>>> For some reason in WSL x86_64-w64-mingw32-pkg-config uses PKG_CONFIG_LIBDIR
>>> and not PKG_CONFIG_PATH and it doesn't find anything.
>>>
>>>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=fbb7265fa138aa4012d570eca9119ab35a3e579b
>>> ---
>>>
>>>   configure.ac | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/configure.ac b/configure.ac
>>> index 1f4ac52374..9b663de0f9 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -464,6 +464,7 @@ AS_IF([test -n "${CONTRIB_DIR}"], [
>>>     CXXFLAGS="${CXXFLAGS} -I${CONTRIB_DIR}/include"
>>>     OBJCFLAGS="${OBJCFLAGS} -I${CONTRIB_DIR}/include -F${CONTRIB_DIR} -F$
>>> {CONTRIB_DIR}/Frameworks"
>>>     export PKG_CONFIG_PATH="${CONTRIB_DIR}/lib/pkgconfig:${CONTRIB_DIR}/
>>> share/pkgconfig:$PKG_CONFIG_PATH"
>>> +  export PKG_CONFIG_LIBDIR="${CONTRIB_DIR}/lib/pkgconfig:$
>>> {CONTRIB_DIR}/share/pkgconfig:$PKG_CONFIG_LIBDIR"
>>>     LDFLAGS="${LDFLAGS} -L${CONTRIB_DIR}/lib"
>>>   
>>>     AS_IF([test -z "$LUAC"], [
>>>
> It is not, and was push --force into oblivion

That's what happens when I touch Linux.