[vlc-devel] [PATCH] aout: audio filters can return NULL

[Thomas Guillem]

On Tue, Feb 19, 2019, at 17:17, Rémi Denis-Courmont wrote:
> Le tiistaina 19. helmikuuta 2019, 18.07.46 EET Thomas Guillem a écrit :
> > Don't count them as lost.
> 
> Correct, but not sure the stat makes sense any longer then.

This is still used if the aout can't be started.
OK, when it happens, you don't need this stat since you won't hear anything anyway.

Ideally, this stat should be incremented when the aout is flushed because of sync issue.

> 
> > ---
> >  src/audio_output/dec.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/src/audio_output/dec.c b/src/audio_output/dec.c
> > index d343cbc745..08666b7c61 100644
> > --- a/src/audio_output/dec.c
> > +++ b/src/audio_output/dec.c
> > @@ -367,7 +367,7 @@ int aout_DecPlay(audio_output_t *aout, block_t *block)
> > 
> >      block = aout_FiltersPlay(owner->filters, block, owner->sync.rate);
> >      if (block == NULL)
> > -        goto lost;
> > +        return ret;
> > 
> >      /* Software volume */
> >      aout_volume_Amplify (owner->volume, block);
> > @@ -384,7 +384,6 @@ int aout_DecPlay(audio_output_t *aout, block_t *block)
> >  drop:
> >      owner->sync.discontinuity = true;
> >      block_Release (block);
> > -lost:
> >      atomic_fetch_add_explicit(&owner->buffers_lost, 1,
> > memory_order_relaxed); return ret;
> >  }
> 
> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel