[vlc-devel] [PATCH] Create video-splitter variable from the core

[Thomas Guillem]

LGTM.

On Wed, Feb 20, 2019, at 15:19, Hugo Beauzée-Luyssen wrote:
> As this variable is inherited from both the player and the legacy
> playlist, it causes libvlc init to fail when the video_splitter module
> isn't present, which is the case for our fuzzer builds
> ---
>  modules/video_output/splitter.c | 2 --
>  src/libvlc-module.c             | 3 ++-
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/modules/video_output/splitter.c b/modules/video_output/splitter.c
> index 1a08848b80..afc024f509 100644
> --- a/modules/video_output/splitter.c
> +++ b/modules/video_output/splitter.c
> @@ -328,6 +328,4 @@ vlc_module_begin()
>      set_subcategory(SUBCAT_VIDEO_VOUT)
>      set_capability("vout display", 0)
>      set_callbacks(vlc_vidsplit_Open, vlc_vidsplit_Close)
> -    add_module("video-splitter", "video splitter", NULL,
> -               N_("Video splitter module"), N_("Video splitter module"))
>  vlc_module_end()
> diff --git a/src/libvlc-module.c b/src/libvlc-module.c
> index 0c5320f0c6..d2aeb5728d 100644
> --- a/src/libvlc-module.c
> +++ b/src/libvlc-module.c
> @@ -1684,7 +1684,8 @@ vlc_module_begin ()
>      set_subcategory( SUBCAT_VIDEO_VOUT )
>      add_module("vout", "vout display", NULL, VOUT_TEXT, VOUT_LONGTEXT)
>          change_short('V')
> -
> +    add_module("video-splitter", "video splitter", NULL,
> +               VIDEO_SPLITTER_TEXT, VIDEO_SPLITTER_LONGTEXT)
>      set_subcategory( SUBCAT_VIDEO_VFILTER )
>      add_module_list("video-filter", "video filter", NULL,
>                      VIDEO_FILTER_TEXT, VIDEO_FILTER_LONGTEXT)
> -- 
> 2.20.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel