[vlc-devel] [PATCH 4/5] playlist_legacy: fix assert if splitter module is missing

[Thomas Guillem]

On Wed, Feb 20, 2019, at 17:58, Rémi Denis-Courmont wrote:
> Le keskiviikkona 20. helmikuuta 2019, 18.39.58 EET Thomas Guillem a écrit :
> > ---
> >  src/playlist_legacy/engine.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/playlist_legacy/engine.c b/src/playlist_legacy/engine.c
> > index 2ffe0980f2..59a6611a11 100644
> > --- a/src/playlist_legacy/engine.c
> > +++ b/src/playlist_legacy/engine.c
> > @@ -432,8 +432,11 @@ static void VariablesInit( playlist_t *p_playlist )
> >      var_Create( p_playlist, "rate-faster", VLC_VAR_VOID );
> >      var_AddCallback( p_playlist, "rate-faster", RateOffsetCallback, NULL );
> > 
> > -    var_Create( p_playlist, "video-splitter", VLC_VAR_STRING |
> > VLC_VAR_DOINHERIT ); -    var_AddCallback( p_playlist, "video-splitter",
> > VideoSplitterCallback, NULL ); +    if (config_GetType("video-splitter"))
> > +    {
> > +        var_Create( p_playlist, "video-splitter", VLC_VAR_STRING |
> > VLC_VAR_DOINHERIT ); +        var_AddCallback( p_playlist,
> > "video-splitter", VideoSplitterCallback, NULL ); +    }
> > 
> >      var_Create( p_playlist, "video-filter", VLC_VAR_STRING |
> > VLC_VAR_DOINHERIT ); var_Create( p_playlist, "sub-source", VLC_VAR_STRING |
> > VLC_VAR_DOINHERIT );
> 
> OK as such but I find it very questionable that video-splitter should get its 
> special snow flake handling out of many many many video options that suffer the 
> same "limitation".

I know, I'm not really happy with that and I did the same for the new player.
Mainly because I didn't want to touch the vout and filters API for 4.0, due to a lack of time.

> 
> -- 
> Rémi Denis-Courmont
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel