[vlc-devel] [PATCH] gnutls: disable False Start

[Rémi Denis-Courmont]

Le vendredi 22 février 2019, 20:18:04 EET Thomas Guillem a écrit :
> On Fri, Feb 22, 2019, at 17:06, Rémi Denis-Courmont wrote:
> > Le vendredi 22 février 2019, 17:18:00 EET Thomas Guillem a écrit :
> > > What about linux distribs ?
> > 
> > That's not my problem anymore than any other bugs in some library versions
> 
> That is my problem then. I don't care who is the culprit, if we can do a fix
> in VLC, we should do it.

No it's not your problem either, unless you are integrator for a Linux 
distribution. You can of course help Linux distros if you want to - though at 
least Debian was already notified and provided one possible solution.

Not all bugs can be fixed within projects that you have commit rights to. This 
cannot be fixed in upstream VLC. There are, regardless of questionable notions 
of "guilt", plainly no known ways to detect broken versus non-broken False 
Start support a priori - unless GnuTLS comes from contribs.

Even if we assumed that GnuTLS 3.6.7 would be fixed as per current GnuTLS 
milestones, there are no ways to know if a distro has applied a patch while 
retaining a "known broken" version number.

This is neither the first nor the last time that VLC is hit by bugs in 
underlying libraries. It would also not be the first time that version number 
checks do not work. We have had far worse issues with e.g. libintl or live555 
crashing, that we could not fix except in contribs. You have to learn to live 
with that.

In other words, you cannot fix bugs against an unknown.

-- 
Rémi Denis-Courmont