[vlc-devel] [PATCH] glwin32: don't release the surface object on Close

Steve Lhomme robux4 at ycbcr.xyz
Mon Feb 25 10:39:00 CET 2019


It's actually a vout_window_t and it seems this code is not supposed to manage
it.

Fixes a crash when using OpenGL on windows.
---
 modules/video_output/win32/glwin32.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/modules/video_output/win32/glwin32.c b/modules/video_output/win32/glwin32.c
index e654455633..0ba41a7c0c 100644
--- a/modules/video_output/win32/glwin32.c
+++ b/modules/video_output/win32/glwin32.c
@@ -180,7 +180,6 @@ static void Close(vout_display_t *vd)
 
     if (gl)
     {
-        vout_window_t *surface = gl->surface;
         if (sys->vgl)
         {
             vlc_gl_MakeCurrent (gl);
@@ -188,7 +187,6 @@ static void Close(vout_display_t *vd)
             vlc_gl_ReleaseCurrent (gl);
         }
         vlc_gl_Release (gl);
-        vlc_object_release(surface);
     }
 
     CommonClean(vd);
-- 
2.17.1



More information about the vlc-devel mailing list