[vlc-devel] [PATCH 3/5] opengl:android: don't lock pictures via the pool

[Steve Lhomme]

Not sure if decoding will still work if the pictures are unlocked by default
during decoding.
This pool will probably move in the decoder anyway. The unlock/lock might have
to be done in the Display() if displaying locked pictures is not possible.
---
 modules/video_output/opengl/converter_android.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/modules/video_output/opengl/converter_android.c b/modules/video_output/opengl/converter_android.c
index 92ddd291fc..e1590a5b87 100644
--- a/modules/video_output/opengl/converter_android.c
+++ b/modules/video_output/opengl/converter_android.c
@@ -107,14 +107,17 @@ tc_anop_get_pool(const opengl_tex_converter_t *tc, unsigned requested_count)
         }
     }
 
-    /* Wrap the pictures into a pool */
+    /* TODO the lock/copy/unlock could be done outside of the pool via a
+     * callback in the OpenGL prepare() */
+#if 0
     picture_pool_configuration_t pool_cfg = {
         .picture_count = requested_count,
         .picture       = picture,
         .lock          = pool_lock_pic,
         .unlock        = pool_unlock_pic,
     };
-    picture_pool_t *pool = picture_pool_NewExtended(&pool_cfg);
+#endif
+    picture_pool_t *pool = picture_pool_New(requested_count, picture);
     if (!pool)
         goto error;
 
-- 
2.17.1