[vlc-devel] [PATCH] glwin32: configure the vlc_gt with the actual vout_window that is used

[Rémi Denis-Courmont]

Le maanantaina 25. helmikuuta 2019, 16.54.48 EET Steve Lhomme a écrit :
> > But more importantly, I don't understand how it works if the display
> > is (supposed to be) embedded? If it creates its own window
> > unilaterally, then won't it always be non-embedded?

Answering myself: if the display is embedded in a video output window, the own 
window is created as a child of the video output window. In other words, there 
are two nested windows for the same screen estate.

> The issue(s) I got were:
> - that this window was created but not used => no display.

Presumably some handling in common.c and/or events.c does not apply to the 
video output window, so it fails if GL is attached directly to it.

> - the vout_window object was released in this module, assuming it's the
> one it created except it wasn't. The core was still making use of that
> vout_window => crash

Of course.

> - the window operations callback were set on the other vout_window that
> is not used (that's after the embedded one was released that the
> callbacks were crashing)

> I think it makes sense to use the vout_window it allocated on purpose.
> Now why it needs that is a mystery to me.

I guess that common.c and events.c are not accounting for that possibility.

> It doesn't work when using the one allocated from the core.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/