[vlc-devel] [PATCH v2 1/1] wayland: add background surface and center video

Alexandre Janniaux ajanni at videolabs.io
Tue Feb 26 16:49:32 CET 2019


Yes, you're right but it happens when we create a surface with
wl_compositor instead of using Qt to create the surface and
I don't want to willingly introduce a crash.

Would you prefer that I create a separate patch to set the input
region on the parent surface first?

On 2019-02-26 16:43, Rémi Denis-Courmont wrote:
> Le tiistaina 26. helmikuuta 2019, 17.31.47 EET Alexandre Janniaux a 
> écrit :
>> +    /* HACK: Clients like Qt can expect every surface to be their 
>> surface,
>> and +     * get events from wl_pointer object, independently of the
>> wl_event_queue +     * set so we avoid these event by disabling them 
>> on
>> this surface. */ +    struct wl_region *input_region =
>> wl_compositor_create_region(sys->compositor); +
>> wl_region_add(input_region, 0, 0, 0, 0);
>> +    wl_surface_set_input_region(sys->surface, input_region);
>> +    wl_region_destroy(input_region);
> 
> This does not seem to be related to this black borders, nor does it 
> seem to
> belong at all - the problem ought to affect any WL display.



More information about the vlc-devel mailing list