[vlc-devel] [PATCH 3/4] kva: replace deprecated APIs

[Rémi Denis-Courmont]

Hi,

The patch looks better than nothing. But vout_window APIs are supposed to be used by window provider plugins, not vout display plugins.

Le 31 décembre 2018 18:25:20 GMT+01:00, KO Myung-Hun <komh78 at gmail.com> a écrit :
>---
> modules/video_output/kva.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
>diff --git a/modules/video_output/kva.c b/modules/video_output/kva.c
>index f319ccee2e..8e657d5481 100644
>--- a/modules/video_output/kva.c
>+++ b/modules/video_output/kva.c
>@@ -180,10 +180,9 @@ static void PMThread( void *arg )
> 
>     sys->b_fixt23 = var_CreateGetBool( vd, "kva-fixt23");
> 
>-    if( !sys->b_fixt23 )
>+    if( !sys->b_fixt23 && vd->cfg->window->type ==
>VOUT_WINDOW_TYPE_HWND )
>         /* If an external window was specified, we'll draw in it. */
>-        sys->parent_window =
>-            vout_display_NewWindow( vd, VOUT_WINDOW_TYPE_HWND );
>+        sys->parent_window = vd->cfg->window;
> 
>     if( sys->parent_window )
>     {
>@@ -968,7 +967,7 @@ static MRESULT EXPENTRY WndProc( HWND hwnd, ULONG
>msg, MPARAM mp1, MPARAM mp2 )
>     {
>         /* the user wants to close the window */
>         case WM_CLOSE:
>-            vout_display_SendEventClose(vd);
>+            vout_window_ReportClose(vd->cfg->window);
>             result = 0;
>             break;
> 
>@@ -1071,7 +1070,7 @@ static MRESULT EXPENTRY WndProc( HWND hwnd, ULONG
>msg, MPARAM mp1, MPARAM mp2 )
>                     if( i_flags & KC_ALT )
>                         i_key |= KEY_MODIFIER_ALT;
> 
>-                    vout_display_SendEventKey(vd, i_key);
>+                    vout_window_ReportKeyPress(vd->cfg->window,
>i_key);
>                 }
>             }
>             break;
>-- 
>2.13.3
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190101/a7a927b0/attachment.html>