[vlc-devel] [PATCH 3/4] avahi: Prepare code for support of renderer discovery

[Brüns, Stefan]

On Donnerstag, 10. Januar 2019 10:05:18 CET Thomas Guillem wrote:
> Hi,
> 
> I prefer to convert p_sys to void * like Remi said. This is how it's done
> for most VLC modules, but not like mdns. But it's not a big deal...

Can you point me to an example where it *is* done?

I looked hard, but:
- bonjour is using two aggregates with identical members as well
- codec uses encoder_sys_t/decoder_sys_t
- filter uses filter_sys_t
...

I could not find a usage of void* casts for these members, or declaration as 
void*, although all are pointers to opaque implementation specific structs.

> Otherwise, I have issue applying your patches:
> 
> "Applying: avahi: Explicitly handle AVAHI_BROWSER_REMOVE events
> error: corrupt patch at line 21"
> 
> Lines are truncated. Could you re-send them (with git send-email) or give us
> an url to your git.

Sure.

Kind regards,

Stefan