[vlc-devel] [PATCH 2/2] linux: Add for kms vout plugin possibility to choose output display

[Juha-Pekka Heikkila]

On 13.1.2019 12.09, Rémi Denis-Courmont wrote:
> Le torstaina 10. tammikuuta 2019, 14.21.54 EET Juha-Pekka Heikkila a écrit :
>> Up to this point kms vout plugin chose first enumerated display to
>> be used for output. Now added parameter --kms-connector which will
>> accept number. List of available connectors are printed out by
>> kms vout plugin in debug prints when run in verbose mode.
> 
> Isn't this better done with the nascent generic fullscreen output selection
> (vout_window_SetFullscreen) interface than a custom parameter?
> 

That sound like it would be coming from windowed system to full screen? 
That would not work with kms as when kms is initialized there cannot be 
other software owning display.

This patch was earlier on list when you suggested to try use 
change_integer_cb() for this selection. Alas this didn't work unless 
running in (qt) gui and back then Filip Roséen and Thomas Guillem seemed 
to agree with commandline parameter instead of making 
change_integer_cb() to work with text terminal. While I agree choosing 
connector this way is bit so'n'so but connectors don't change order or 
place so the correct number need to be checked from verbose info only once.

I'd guess most normal situation is where there are maximum of two 
connected displays and from this I'm thinking I'd give numbers only to 
connected displays. This would often mean on laptop default screen is 
'1' and external screen would be '2'...I think this way using connector 
parameter would become reasonable?

/Juha-Pekka