[vlc-devel] [PATCH 2/2] 3d anaglyph: rename "over-under" to "top-bottom"

[Steve Lhomme]

Please squash the 2 patches. There's no need to review a patch that just 
does renaming (unless it prepares for bigger changes).

On 16/01/2019 04:43, Tom Murphy wrote:
> ---
>   modules/video_filter/anaglyph.c | 18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/modules/video_filter/anaglyph.c b/modules/video_filter/anaglyph.c
> index 4ec38fc90a..4bf8a228f5 100644
> --- a/modules/video_filter/anaglyph.c
> +++ b/modules/video_filter/anaglyph.c
> @@ -37,7 +37,7 @@ static void Destroy(vlc_object_t *);
>   static picture_t *Filter(filter_t *, picture_t *);
>   
>   static void combine_side_by_side_yuv420(picture_t *, picture_t *, int, int);
> -static void combine_over_under_yuv420(picture_t *, picture_t *, int, int);
> +static void combine_top_bottom_yuv420(picture_t *, picture_t *, int, int);
>   
>   #define SCHEME_TEXT N_("Color scheme")
>   #define SCHEME_LONGTEXT N_("Define the glasses' color scheme")
> @@ -60,7 +60,7 @@ enum scheme_e
>   enum orientation_e
>   {
>       side_by_side = 1,
> -    over_under,
> +    top_bottom,
>   };
>   
>   static const char *const ppsz_scheme_values[] = {
> @@ -80,11 +80,11 @@ static const char *const ppsz_scheme_descriptions[] = {
>   
>   static const char *const orientation_values[] = {
>       "side-by-side",
> -    "over-under",
> +    "top-bottom",
>       };
>   static const char *const orientation_descriptions[] = {
>       "side-by-side",
> -    "over-under",
> +    "top-bottom",
>       };
>   
>   vlc_module_begin()
> @@ -190,8 +190,8 @@ static int Create(vlc_object_t *p_this)
>       {
>           if (!strcmp(orientation_choice, "side-by-side"))
>               p_sys->orientation = side_by_side;
> -        else if (!strcmp(orientation_choice, "over-under"))
> -            p_sys->orientation = over_under;
> +        else if (!strcmp(orientation_choice, "top-bottom"))
> +            p_sys->orientation = top_bottom;
>           else
>               msg_Err(p_filter, "Unknown anaglyph orientation '%s'", orientation_choice);
>       }
> @@ -233,8 +233,8 @@ static picture_t *Filter(filter_t *p_filter, picture_t *p_pic)
>                       combine_side_by_side_yuv420(p_pic, p_outpic,
>                                                   p_sys->left, p_sys->right);
>                       break;
> -                case over_under:
> -                    combine_over_under_yuv420(p_pic, p_outpic,
> +                case top_bottom:
> +                    combine_top_bottom_yuv420(p_pic, p_outpic,
>                                                   p_sys->left, p_sys->right);
>                       break;
>                   default:
> @@ -360,7 +360,7 @@ static void combine_side_by_side_yuv420(picture_t *p_inpic, picture_t *p_outpic,
>   
>   
>   
> -static void combine_over_under_yuv420(picture_t *p_inpic, picture_t *p_outpic,
> +static void combine_top_bottom_yuv420(picture_t *p_inpic, picture_t *p_outpic,
>                                           int left, int right)
>   {
>       uint8_t *yino = p_inpic->p[Y_PLANE].p_pixels;
> -- 
> 2.11.0
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel