[vlc-devel] [PATCH] display: fix a few warnings
Johan Gunnarsson
johan.gunnarsson at gmail.com
Wed Jan 16 21:26:15 CET 2019
video_output/display.c: In function ‘VoutDisplayCreateRender’:
video_output/display.c:341:9: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
int ret;
^~~
video_output/display.c: In function ‘vout_display_TranslateMouseState’:
video_output/display.c:262:23: warning: ‘y’ may be used uninitialized in this function [-Wmaybe-uninitialized]
+ (int64_t)(y - place.y) * vd->source.i_visible_height / place.height;
~~~^~~~~~~~~~
video_output/display.c:260:23: warning: ‘x’ may be used uninitialized in this function [-Wmaybe-uninitialized]
+ (int64_t)(x - place.x) * vd->source.i_visible_width / place.width;
~~~^~~~~~~~~~
---
src/video_output/display.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/video_output/display.c b/src/video_output/display.c
index be744e0b98..471bbd0b3b 100644
--- a/src/video_output/display.c
+++ b/src/video_output/display.c
@@ -219,7 +219,7 @@ void vout_display_TranslateMouseState(vout_display_t *vd, vlc_mouse_t *video,
}
const int wx = window->i_x, wy = window->i_y;
- int x, y;
+ int x = wx, y = wy;
switch (vd->source.orientation) {
case ORIENT_TOP_LEFT:
@@ -338,7 +338,7 @@ static int VoutDisplayCreateRender(vout_display_t *vd)
es_format_InitFromVideo(&src, &v_src);
/* */
- int ret;
+ int ret = -1;
for (int i = 0; i < 1 + (v_dst_cmp.i_chroma != v_dst.i_chroma); i++) {
es_format_t dst;
--
2.17.1
More information about the vlc-devel
mailing list