[vlc-devel] [PATCH] Addressed items in original AMT code submission and added FQDN support

[Steve Lhomme]

You should use "git send-email" it will send separate emails for each 
patches. But in this cases all your patches should go into a single one.

On 15/01/2019 01:17, Wayne Brassem wrote:
> Addressing items raised in 
> https://mailman.videolan.org/pipermail/vlc-devel/2018-November/121776.html and 
> added FQDN support to the AMT code.
> AMT stands for Automatic Multicast Tunnelling and allow the user to 
> receive multicast streams over an non-multicast enabled network by 
> tunnelling through an AMT relay.
>
> From 91ef0bbc4b43eceaa3aea6cb2710232370a67ec8 Mon Sep 17 00:00:00 2001
> From: Wayne Brassem <wbrassem at rogers.com <mailto:wbrassem at rogers.com>>
> Date: Mon, 14 Jan 2019 18:25:02 -0500
> Subject: [PATCH 1/3] Addressed items in original AMT code submission 
> and added
>  FQDN support
>
> ---
>  modules/access/Makefile.am | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/modules/access/Makefile.am b/modules/access/Makefile.am
> index c56cb8fe3a..792c6efb04 100644
> --- a/modules/access/Makefile.am
> +++ b/modules/access/Makefile.am
> @@ -373,6 +373,10 @@ libudp_plugin_la_SOURCES = access/udp.c
>  libudp_plugin_la_LIBADD = $(SOCKET_LIBS)
>  access_LTLIBRARIES += libudp_plugin.la <http://libudp_plugin.la>
>
> +libamt_plugin_la_SOURCES = access/amt.c access/amt.h
> +libamt_plugin_la_LIBADD = $(SOCKET_LIBS)
> +access_LTLIBRARIES += libamt_plugin.la <http://libamt_plugin.la>

This can't be a separate patch from 2/3, it will break the build.

> +
>  libunc_plugin_la_SOURCES = access/unc.c access/smb_common.h
>  libunc_plugin_la_LIBADD = -lmpr -lnetapi32
>  if HAVE_WIN32
> -- 
> 2.17.2 (Apple Git-113)
>
> From 91c757f47445095ac8de8574a8b216cca3043898 Mon Sep 17 00:00:00 2001
> From: Wayne Brassem <wbrassem at rogers.com <mailto:wbrassem at rogers.com>>
> Date: Mon, 14 Jan 2019 18:47:06 -0500
> Subject: [PATCH 2/3] Addressed concerns in first submissions and added 
> support
>  for FQDN
>
> -- 
> 2.17.2 (Apple Git-113)
>
> From 72ea76afdb7679f11e19b0ac2cba6c81ec1aed33 Mon Sep 17 00:00:00 2001
> From: Wayne Brassem <wbrassem at rogers.com <mailto:wbrassem at rogers.com>>
> Date: Mon, 14 Jan 2019 18:48:17 -0500
> Subject: [PATCH 3/3] Modifed function declarations

Since you're adding amt.h in the previous patch, just squash them into one.