[vlc-devel] [PATCH] decklink: Fix compile breakage on MacOS

Marvin Scholz epirat07 at gmail.com
Fri Jan 18 17:43:44 CET 2019


On 18 Jan 2019, at 17:16, Devin Heitmueller wrote:

> The following commit broke compilation of the decklink modules on
> OSX, since CFStringRef is already const.
>
> commit 651c58b9b4b1666116046ce3e496303704ba202a
> Author: Marvin Scholz <epirat07 at gmail.com>
> Date:   Mon Oct 22 09:27:21 2018 +0200
>

Sorry for breaking that, weird that I did not notice it failing
locally… Thanks for the fix, merged.

>     Decklink: Use typedef instead of macro
>
> Signed-off-by: Devin Heitmueller <dheitmueller at ltnglobal.com>
> ---
>  modules/access/vlc_decklink.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/modules/access/vlc_decklink.h b/modules/access/vlc_decklink.h
> index 9855050f64..5faa7acc4a 100644
> --- a/modules/access/vlc_decklink.h
> +++ b/modules/access/vlc_decklink.h
> @@ -37,7 +37,7 @@
>  #elif defined(__APPLE__)
>  #include <vlc_common.h>
>  #include <vlc_charset.h>
> -typedef const CFStringRef decklink_str_t;
> +typedef CFStringRef decklink_str_t;
>  #define DECKLINK_STRDUP(s) FromCFString(s, kCFStringEncodingUTF8)
>  #define DECKLINK_FREE(s) CFRelease(s)
>  #else
> -- 
> 2.13.2
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list