[vlc-devel] [PATCH] compat: work-around busted FreeBSD qsort_r()

[David Fuhrmann]

Hi,

I checked all FreeBSD Versions 3 to 12, and macOS SDKs 10.7, 10.12, 10.13 and 10.14. All have the same include guard, and that since ages. So I think it is safe to assume that it stays as it is for now.

BTW, qsort_r exists in its FreeBSD variant since ages already. According to https://stackoverflow.com/questions/39560773/different-declarations-of-qsort-r-on-mac-and-linux, FreeBSD introduced its variant in 2002, whereas Linux added the other variant in 2008.

Maybe VLC should not use such a function directly with such a long history of incompatible signature, and where the FreeBSD variant is even older?
And from my understanding, qsort_r is in no standard as of today either.

Best,
David

> Am 19.01.2019 um 16:35 schrieb Rémi Denis-Courmont <remi at remlab.net>:
> 
> 	Hey,
> 
> Are you sure that we can assume the stdlib.h guard on all affected platforms? 
> It definitely cannot be done on all platforms - but that's not really the 
> question.
> 
> Br,
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel