[vlc-devel] [PATCH] compat: work-around busted FreeBSD qsort_r()
rom1v at videolabs.io
Mon Jan 21 10:06:11 CET 2019
On Mon, Jan 21, 2019 at 09:15:14AM +0100, Steve Lhomme wrote:
> On 19/01/2019 20:39, Marvin Scholz wrote:
> > I think it would be confusing to just "overwrite" the qsort_r prototype
> > with
> > the one we want to use in VLC as at least I would be quite confused when
> > qsort_r does not match the qsort_r of my system headers.
> > IMO a good approach would be to introduce a vlc_qsort_r or similar
> > named, so
> > that it becomes obvious that it does not necessarily matches the system
> > qsort_r.
> > (And yes, putting that in compat was not a good idea.)
> I second that.
+1 for vlc_qsort_r()
More information about the vlc-devel