[vlc-devel] [PATCH V2 2/8] configure: add HAVE_FREEBSD detection

[Rémi Denis-Courmont]

I don't think that's acceptable, and that is definitely not in line with our existing configure script practices.

Le 22 janvier 2019 14:36:01 GMT+02:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>
>On Tue, Jan 22, 2019, at 13:07, Rémi Denis-Courmont wrote:
>> This seems shortsighted. There are plenty of other BSD variants, and
>we are not soon done with this if we have to hand-code detection.
>
>Then we'll add them when needed. I don't know anything about *bsd*. The
>goal here is to fix the macOS/iOS build.
>
>> 
>> Le 22 janvier 2019 12:13:19 GMT+02:00, Thomas Guillem
><thomas at gllm.fr> a écrit :
>>>  configure.ac | 1 +
>>>  1 file changed, 1 insertion(+)
>>> 
>>> diff --git a/configure.ac b/configure.ac
>>> index 1b63a74736..a594054b66 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -320,6 +320,7 @@ AM_CONDITIONAL([HAVE_LINUX],   [test "${SYS}" =
>"linux"])
>>>  AM_CONDITIONAL([HAVE_OS2],     [test "${SYS}" = "os2"])
>>>  
>>>  AM_CONDITIONAL([HAVE_DARWIN],  [test "${SYS}" = "darwin"])
>>> +AM_CONDITIONAL([HAVE_FREEBSD], [test "${SYS}" = "freebsd" -o
>"${SYS}" = "darwin"])
>>>  AM_CONDITIONAL([HAVE_IOS],     [test "${HAVE_IOS}" = "1"])
>>>  AM_CONDITIONAL([HAVE_OSX],     [test "${HAVE_OSX}" = "1"])
>>>  AM_CONDITIONAL([HAVE_TVOS],    [test "${HAVE_TVOS}" = "1"])
>> 
>> -- 
>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez
>excuser ma brièveté. 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190122/4b5fffe9/attachment.html>