[vlc-devel] [PATCH V3 1/7] vlc_common: implement VLC_WEAK for MACH-O

[Hugo Beauzée-Luyssen]

On Tue, Jan 22, 2019, at 4:45 PM, Rémi Denis-Courmont wrote:
> Le tiistaina 22. tammikuuta 2019, 15.30.05 EET Thomas Guillem a écrit :
> > ---
> >  include/vlc_common.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/vlc_common.h b/include/vlc_common.h
> > index 060630ce50..55866a9067 100644
> > --- a/include/vlc_common.h
> > +++ b/include/vlc_common.h
> > @@ -185,7 +185,7 @@
> >  # define VLC_USED
> >  #endif
> > 
> > -#ifdef __ELF__
> > +#if defined (__ELF__) || defined (__MACH__)
> >  # define VLC_WEAK __attribute__((weak))
> >  #else
> >  /**
> 
> Obviously correct but I don't know if Hugo still has a beef with it.
> 

To clarify my previous reply: I don't mind using weak symbols at all.

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr