[vlc-devel] [PATCH] Added FBS demux

Francois Cartegnie fcvlcdev at free.fr
Mon Jul 1 16:42:05 CEST 2019


Le 29/06/2019 à 02:20, bkurniawan at orecx.com a écrit :
> From: budi-kurniawan <budi2020 at gmail.com>
> +    p_sys->seeking = false;
> +    if (vlc_stream_Peek(p_demux->s, &p_peek, 2000) < 2000) {
> +        return VLC_EGENERIC;
> +    }
> +

Seems you don't understand the issue with writing or accessing arbitrary
offsets of data, and that "fix" isn't even valid.

Heap overflows are everywhere in your code.

-- 
Francois Cartegnie
VideoLAN - VLC Developer


More information about the vlc-devel mailing list