[vlc-devel] [PATCH] libvlc: Do not include revision.c file

[Steve Lhomme]

LGTM

With libtool it uses the same .lo for the core and libvlc. If it changes 
it's recompiled for the core and the new object is used to link libvlc.

On 2019-07-02 13:33, Marvin Scholz wrote:
> Instead of including the revision.c file, add it to the sources
> of the library.
> ---
>   lib/Makefile.am | 3 ++-
>   lib/core.c      | 1 -
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/Makefile.am b/lib/Makefile.am
> index 90ac01c7a8..f3fc2321cc 100644
> --- a/lib/Makefile.am
> +++ b/lib/Makefile.am
> @@ -51,7 +51,8 @@ libvlc_la_SOURCES = \
>   	media_list_path.h \
>   	media_list_player.c \
>   	media_discoverer.c \
> -	picture.c
> +	picture.c \
> +	../src/revision.c
>   EXTRA_DIST = libvlc.pc.in libvlc.sym ../include/vlc/libvlc_version.h.in

It does

>   libvlc_la_LIBADD = ../src/libvlccore.la ../compat/libcompat.la $(LIBM)
> diff --git a/lib/core.c b/lib/core.c
> index 06fd52fbfa..52549a139d 100644
> --- a/lib/core.c
> +++ b/lib/core.c
> @@ -34,7 +34,6 @@
>   #include <limits.h>
>   #include <assert.h>
>   
> -#include "../src/revision.c"
>   
>   libvlc_instance_t * libvlc_new( int argc, const char *const *argv )
>   {
> -- 
> 2.20.1 (Apple Git-117)
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>