[vlc-devel] [PATCH] contrib: bootstrap: Use python3

[Steve Lhomme]

On 2019-07-03 10:19, Rémi Denis-Courmont wrote:
> No, you did not.

I'm sorry but I know I did.
And I just did again:

robux4 at DESKTOP-5GFFSHT:~$ python --version
Python 2.7.15+
robux4 at DESKTOP-5GFFSHT:~$ python -c "import os; 
print(os.path.relpath('/src', '/tmp'))"
../src


 >
  I already pointed that out in the then review, but Who Cares? This 
calls python as interpreter which assumes Python 2.

Your comment on the patch was:

I don't think we should depend on Python, at least not until distros 
settle how it works post removal of Python 2.



> Le 3 juillet 2019 08:34:19 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>> I made sure it works with python 2 and 3. What problem would this solve
>> ?
>>
>> (note: meson needs python3 so already require it anyway, so I'd be OK
>> with this change)
>>
>> On 2019-07-02 11:12, Hugo Beauzée-Luyssen wrote:
>>> ---
>>>    contrib/bootstrap | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/contrib/bootstrap b/contrib/bootstrap
>>> index 5e3f266932..1f9079fd73 100755
>>> --- a/contrib/bootstrap
>>> +++ b/contrib/bootstrap
>>> @@ -379,9 +379,9 @@ esac
>>>    BOOTSTRAP_PATH="$( cd "$(dirname "$0")" ; pwd -P )"
>>>    CURRENT_PATH="$( pwd -P )"
>>>    # location of the contrib/src folder from the root of the contrib
>> build folder
>>> -TOPSRC=$(python -c "import os;
>> print(os.path.relpath('$BOOTSTRAP_PATH', '$CURRENT_PATH'))")
>>> +TOPSRC=$(python3 -c "import os;
>> print(os.path.relpath('$BOOTSTRAP_PATH', '$CURRENT_PATH'))")
>>>    # location of the contrib/src folder from a built library folder
>>> -TOPSRC_BUILT=$(python -c "import os;
>> print(os.path.relpath('$BOOTSTRAP_PATH', '$CURRENT_PATH/libfoo'))")
>>> +TOPSRC_BUILT=$(python3 -c "import os;
>> print(os.path.relpath('$BOOTSTRAP_PATH', '$CURRENT_PATH/libfoo'))")
>>>    add_make "TOPSRC = $TOPSRC"
>>>    add_make "TOPSRC_BUILT = $TOPSRC_BUILT"
>>>    add_make "TOPDST = .."
>>> -- 
>>> 2.20.1
>>>
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>