[vlc-devel] slave clock conversion and pause state

[Thomas Guillem]

On Thu, Jul 4, 2019, at 13:26, Francois Cartegnie wrote:
> The new clock returns INT64_MAX when the pause is active.
> 
> This prevents timestamp conversion in background processing, and somehow
> is not compatible with recent spu change (reconversion each frame to
> handle live delay changes) when slave & paused.
> 
> I'm wondering why it is needed to return INT64_MAX instead of a frozen
> time like the master does.
> 
> static vlc_tick_t vlc_clock_slave_to_system_locked(vlc_clock_t *clock,
>                                                    vlc_tick_t now,
>                                                    vlc_tick_t ts, double
> rate)
> {
>     vlc_clock_main_t *main_clock = clock->owner;
>     if (main_clock->pause_date != VLC_TICK_INVALID)
>         return INT64_MAX;

Sorry, I don't remember when we added this check. Typx, do you remember ?
I think it can be removed (but tested first).

> 
> 
> -- 
> Francois Cartegnie
> VideoLAN - VLC Developer
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel