[vlc-devel] [PATCH] VLC as UPnP/DLNA MediaRenderer

[Alexandre Janniaux]

Hi,

This is a nice feature to have !

> Using the player seems rather dubious here. This should probably use its own 
> private input instead.

I don't really see the use case for using input_thread instead of the player:

+ Having always the same kind of code in the same modules types is easier to
  maintain as you can easily compare with other modules.
+ It also avoid rewriting new code/special case just for one module.
+ It widden the usage of vlc_player and would help reduce bug on it.
+ It would bring feedback on what's bad on player API (and in this case playlist
  too, even if it's debatable).
+ If I understood the previous player/playlist/vout patches and what was told on
  the workshops, the goal is to privatise input_thread into the core, which has
  already been partially done currently.

Did you mean playlist instead of player ? Or something else instead of
input_thread ?

> Do we want the current playback to stop, or it to be shown on the side?
> I'm very much unsure.

This could be exposed as a global parameter if we are to add other renderers,
copying vlc_intf_GetMainPlaylist into vlc_intf_GetRendererPlaylist. The core
could even add callbacks to the returned playlist so it could pause the main
playlist when the renderer playlist is starting to play an item. But in any case
I would say it is quite independent of this patchset as there is currently no
renderer in VLC and it can be decided afterwards to improve this behaviour after
real life testing if you agree on this.

Greats

-- 
Alexandre Janniaux
VideoLabs

On Tue, Jul 09, 2019 at 06:52:51PM +0200, Jean-Baptiste Kempf wrote:
> On Tue, Jul 9, 2019, at 16:28, Rémi Denis-Courmont wrote:
> > Le lauantaina 6. heinäkuuta 2019, 18.13.05 EEST Johan Gunnarsson a écrit :
> > > This adds support for VLC to act as a UPnP/DLNA MediaRenderer on the
> > > LAN. This means a UPnP/DLNA control point can "cast" media to a VLC
> > > instance and control playback.
> > 
> > Using the player seems rather dubious here. This should probably use its own 
> > private input instead.
> 
> That's a good question, and is the one I asked on IRC.
> 
> It's debatable whether you want the main playlist to show what was sent to the renderer, or not.
> 
> Do we want the current playback to stop, or it to be shown on the side?
> I'm very much unsure.
> 
> -- 
> Jean-Baptiste Kempf -  President
> +33 672 704 734
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel