[vlc-devel] [PATCH 1/2] vout: spu: swap original/converted time

[Francois Cartegnie]

Le 10/07/2019 à 10:27, Thomas Guillem a écrit :
>> +    /* Convert all spu ts */
>> +    vlc_tick_t orgstart = subpic->i_start;
>> +    vlc_tick_t orgstop = subpic->i_stop;
>> +    if (channel->clock)
>> +    {
>> +        vlc_tick_t system_now = vlc_tick_now();
>> +        vlc_tick_t times[2] = { subpic->i_start, subpic->i_stop };
>> +        vlc_clock_ConvertArrayToSystem(channel->clock, system_now,
>> +                                       times, 2, channel->rate);
> 
> Could you explain why this extra conversion is needed ? Why not using the one from spu_channel_UpdateDates() ?
> 

That would move spu_channel_UpdateDates into spu_Channel_Push() and then
make it less suitable for generic usage.

We just don't need it, just call simple real timestamp conversion ourself.

-- 
Francois Cartegnie
VideoLAN - VLC Developer