[vlc-devel] [PATCH] RFC: http: add support for byte range requests

[Thomas Guillem]

On Mon, Jun 17, 2019, at 10:13, Rémi Denis-Courmont wrote:
> Hi,
> 
> There is no explanation why this is needed, and how this won't hurt performance badly where it's used, or make things more complicated for no benefits.
> 
> I don't disagree that this won't affect normal HTTP streaming, and that's not the point.

Maybe this RFC lack some comments, but we all have guessed that this patch will be used for adaptive.

cf. https://trac.videolan.org/vlc/ticket/22339

I think Francois is doing what you suggested: using and modifying the lower HTTP API.

So LGTM, but you should add some rational in documentation or commit logs.


> 
> Le 17 juin 2019 09:23:19 GMT+03:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>> hi,
>> 
>> On Sat, Jun 15, 2019, at 07:53, Rémi Denis-Courmont wrote:
>>> 	Hi,
>>> 
>>> Streaming in ranges breaks pipelining and cannot work properly if the RTT is 
>>> non-negligible. Sequential streaming must use a half-open range.
>>> 
>>> Likewise multi-track (like AVI) streaming needs to use multiple half-open 
>>> ranges in parallel, in other words, multiple streams - and that is not specific 
>>> to HTTP at all.
>> 
>> Range request will be only used for adaptive, why are talking about .avi ?
>> 
>> > 
>>> New stream must only be used when unavoidable - notably when seeking or 
>>> getting a different resource (e.g. rate switch).
>>> 
>>> This patch has zero rationale. Nack.
>> 
>> This patch doesn't change the actual http access behavior. This new function will only be used by adaptive in order to refactor *a lot* of code.
>> 
>> I really don't understand your refusal ? Could you explain what should be done then ?
>> 
>> > 
>>> -- 
>>> Rémi Denis-Courmontvlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190711/b2f1f9fa/attachment.html>