[vlc-devel] [PATCH v2 1/5] upnp: Add basic support for registering MediaRenderer service
jb at videolan.org
Tue Jul 16 10:42:51 CEST 2019
I understood the idea. But explain that in the commit and comments.
On Tue, Jul 16, 2019, at 10:41, Johan Gunnarsson wrote:
> Yes, I will do this. For the record, it's because I want to make the
> UPnP client handle and UPnP device handle independent of each other.
> That way, I don't have to register the renderer service and run the
> web server unless the renderer control is actually used. I foresee a
> future where there's an option to disable the renderer control, but
> still be able to use the UPnP device discovery.
> Den sön 14 juli 2019 kl 11:49 skrev Jean-Baptiste Kempf <jb at videolan.org>:
> > Tbh, you should explain a bit what you are doing in this commit (handle -> client_handle) and why you need different handles and refcounting.
> > Also, why this needs to be in the upnp-wrapper...
> > I think I understand why for both, but the commit message and the comments in the code should reflect this.
Jean-Baptiste Kempf - President
+33 672 704 734
More information about the vlc-devel