[vlc-devel] [vlc-commits] avcodec: encoder: fix MPEG4 matrix passed as const

[Steve Lhomme]

On 2019-07-16 20:02, Rémi Denis-Courmont wrote:
> Le maanantaina 15. heinäkuuta 2019, 12.30.14 EEST Steve Lhomme a écrit :
>> On 2019-07-15 11:26, Rémi Denis-Courmont wrote:
>>> Hi,
>>>
>>> Not claiming that it's wrong, but how could it not crash if FFmpeg freed a
>>> pointer to .rodata?
>> I think no one uses this code. Or if it crashes at the end of an encode
>> people don't really care as long as they have their file.
> 
> And we can't just pass NULL-or-something and let FFmpeg pick defaults?

b_mpeg4_matrix = var_GetBool( p_enc, ENC_CFG_PREFIX "mpeg4-matrix" );

We do, optionally. The default is false.