[vlc-devel] [vlc-commits] avcodec: encoder: fix MPEG4 matrix passed as const

[Steve Lhomme]

On 2019-07-17 8:16, Rémi Denis-Courmont wrote:
> Hi,
> 
> Uh, but what's the point in choosing between the default and a copy of the default?? Should this setting not be removed?

I'll check if it's the same values.
If so it should be removed indeed.

> Le 17 juillet 2019 08:48:50 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>> On 2019-07-16 20:02, Rémi Denis-Courmont wrote:
>>> Le maanantaina 15. heinäkuuta 2019, 12.30.14 EEST Steve Lhomme a
>> écrit :
>>>> On 2019-07-15 11:26, Rémi Denis-Courmont wrote:
>>>>> Hi,
>>>>>
>>>>> Not claiming that it's wrong, but how could it not crash if FFmpeg
>> freed a
>>>>> pointer to .rodata?
>>>> I think no one uses this code. Or if it crashes at the end of an
>> encode
>>>> people don't really care as long as they have their file.
>>>
>>> And we can't just pass NULL-or-something and let FFmpeg pick
>> defaults?
>>
>> b_mpeg4_matrix = var_GetBool( p_enc, ENC_CFG_PREFIX "mpeg4-matrix" );
>>
>> We do, optionally. The default is false.
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>