[vlc-devel] [PATCH 2/2] Use set_callback() where applicable

[Steve Lhomme]

On 2019-07-17 22:26, Rémi Denis-Courmont wrote:
> diff --git a/include/vlc_renderer_discovery.h b/include/vlc_renderer_discovery.h
> index 8c13a4a9da..e703551e5f 100644
> --- a/include/vlc_renderer_discovery.h
> +++ b/include/vlc_renderer_discovery.h
> @@ -212,7 +212,7 @@ static int vlc_rd_probe_open(vlc_object_t *obj) \
>   #define VLC_RD_PROBE_SUBMODULE \
>       add_submodule() \
>           set_capability("renderer probe", 100) \
> -        set_callbacks(vlc_rd_probe_open, NULL)
> +        set_callback(vlc_rd_probe_open)
>   
>   /** @} @} */
>   
> diff --git a/include/vlc_services_discovery.h b/include/vlc_services_discovery.h
> index e7b0e7b6e1..4b308d6bc7 100644
> --- a/include/vlc_services_discovery.h
> +++ b/include/vlc_services_discovery.h
> @@ -223,7 +223,7 @@ VLC_API int vlc_sd_probe_Add(vlc_probe_t *, const char *, const char *, int cate
>   #define VLC_SD_PROBE_SUBMODULE \
>       add_submodule() \
>           set_capability( "services probe", 100 ) \
> -        set_callbacks( vlc_sd_probe_Open, NULL )
> +        set_callback( vlc_sd_probe_Open)

Odd parenthesis spacing (here and in many other places). Either you keep 
the spacing remove it altogether.