[vlc-devel] [RFC PATCH 0/2] Delay INPUT_UPDATE_TITLE emission

Hugo Beauzée-Luyssen hugo at beauzee.fr
Thu Jul 18 17:57:22 CEST 2019


MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Hi,

This is a small RFC patchset to reduce the amount of INPUT_UPDATE_TITLE
events we send, and to only send them when the title has actually
changed.
The dvdnav patch should definitely be replicated to dvdread, and most
likely to some other demuxers before the input patch can be applied, but
this is a minimal set for review in case I'm just doing it wrong.

The rationale for reducing the amount of events is that we'd like to
automatically restore the last known position (among other things) when
the user restarts a playback, but if we react to an early
INPUT_UPDATE_TITLE to change the position, the seek gets rejected as the
title isn't ready. In the case of dvdnav, dvdnav_get_position will
return an error and the seek will be aborted

Hugo Beauzée-Luyssen (2):
  dvdnav: Notify of title changes when dvdnav notifies us
  input: Don't send an VLC_INPUT_TITLE_SELECTED event

 modules/access/dvdnav.c | 15 ---------------
 src/input/input.c       |  4 ----
 2 files changed, 19 deletions(-)

-- 
2.20.1



More information about the vlc-devel mailing list