[vlc-devel] [RFC PATCH 2/2] input: Don't send an VLC_INPUT_TITLE_SELECTED event

Thomas Guillem thomas at gllm.fr
Thu Jul 18 18:01:14 CEST 2019


LGTM

On Thu, Jul 18, 2019, at 17:56, Hugo Beauzée-Luyssen wrote:
> The demux already takes care of it

nit: the input already takes care of it via the demuxer, cf. UpdateTitleSeekpointFromDemux()

> ---
>  src/input/input.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/src/input/input.c b/src/input/input.c
> index d4639de45c..1a74a3d74a 100644
> --- a/src/input/input.c
> +++ b/src/input/input.c
> @@ -2115,10 +2115,6 @@ static bool Control( input_thread_t *p_input,
>              es_out_Control( priv->p_es_out, ES_OUT_RESET_PCR );
>              demux_Control( priv->master->p_demux,
>                             DEMUX_SET_TITLE, i_title );
> -            input_SendEventTitle( p_input, &(struct vlc_input_event_title) {
> -                .action = VLC_INPUT_TITLE_SELECTED,
> -                .selected_idx = i_title,
> -            });
>              break;
>          }
>          case INPUT_CONTROL_SET_SEEKPOINT:
> -- 
> 2.20.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list