[vlc-devel] [vlc-commits] vout/ios: fix execution

[Felix Paul Kühne]

Hi Steve,

Thanks for the review.

> On 23. Jul 2019, at 06:50, Steve Lhomme <robux4 at ycbcr.xyz> wrote:
> 
> On 2019-07-22 18:42, Felix Paul Kühne wrote:
>> vlc | branch: master | Felix Paul Kühne <felix at feepk.net> | Mon Jul 22 18:26:58 2019 +0200| [9db9c1121193c2a201eb37e9858a603509f684a6] | committer: Felix Paul Kühne
>> vout/ios: fix execution
>>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=9db9c1121193c2a201eb37e9858a603509f684a6
>> ---
>>  modules/video_output/ios.m | 6 +-----
>>  1 file changed, 1 insertion(+), 5 deletions(-)
>> diff --git a/modules/video_output/ios.m b/modules/video_output/ios.m
>> index cd7a49cebf..e77cc93ea5 100644
>> --- a/modules/video_output/ios.m
>> +++ b/modules/video_output/ios.m
>> @@ -147,7 +147,7 @@ static int Open(vout_display_t *vd, const vout_display_cfg_t *cfg,
>>      if (vout_display_cfg_IsWindowed(cfg))
>>          return VLC_EGENERIC;
>>  -    vout_display_sys_t *sys = vlc_obj_calloc(vd, 1, sizeof(*sys));
>> +    vout_display_sys_t *sys = calloc(1, sizeof(*sys));
> 
> This does not seem right. Now the pointer is not free'd automatically with the module anymore.

OK, will fix for both the iOS and macOS vout then. This change was done to synchronize both and I apparently opted for the less capable solution.

Best regards,

Felix