[vlc-devel] [PATCH] contrib: chromaprint: remove dependency on .ffmpeg

[Alexandre Janniaux]

Without this, you'll end up compiling ffmpeg even if you have it on the
system's target directory as soon as you're asking for chromaprint contribs.

The contrib build system already correctly opt-out dependencies that exists
on the target (currently in case you're not in cross-compilation).

On Tue, Jul 23, 2019 at 06:47:23AM +0200, Steve Lhomme wrote:
> Seems OK. Does it solve anything for you ?
>
> On 2019-07-22 17:21, Alexandre Janniaux wrote:
> > This dependency is already setup by the dependency propagation at
> > the end of the main.mak makefile.
> > ---
> >   contrib/src/chromaprint/rules.mak | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/contrib/src/chromaprint/rules.mak b/contrib/src/chromaprint/rules.mak
> > index 235b2cdd99..2ca2d4de4d 100644
> > --- a/contrib/src/chromaprint/rules.mak
> > +++ b/contrib/src/chromaprint/rules.mak
> > @@ -20,7 +20,7 @@ chromaprint: chromaprint-$(CHROMAPRINT_VERSION).tar.gz .sum-chromaprint
> >
> >   DEPS_chromaprint = ffmpeg $(DEPS_ffmpeg)
> >
> > -.chromaprint: chromaprint .ffmpeg toolchain.cmake
> > +.chromaprint: chromaprint toolchain.cmake
> >   	cd $< && $(HOSTVARS_PIC) $(CMAKE) -DBUILD_SHARED_LIBS:BOOL=OFF
> >   	cd $< && $(MAKE) install
> >   	touch $@
> > --
> > 2.22.0
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> >
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel